Prototype for rejecting MSAL cached token based on AuthOperation #5567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what the purpose for this is, but you cannot add a method to an itnerface. See #5376 |
bgavrilMS
reviewed
Nov 4, 2025
|
|
||
| MsalAccessTokenCacheItem cachedAccessTokenItem = await GetCachedAccessTokenAsync().ConfigureAwait(false); | ||
|
|
||
| // Validate the cached token using the authentication operation |
bgavrilMS
reviewed
Nov 4, 2025
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Compile Include="AuthScheme\MsalCacheValidationData.cs" /> |
bgavrilMS
reviewed
Nov 4, 2025
| /// </summary> | ||
| /// <param name="cachedTokenItem"></param> | ||
| /// <returns></returns> | ||
| bool ValidateCachedToken(MsalCacheValidationData cachedTokenItem); |
There was a problem hiding this comment.
naming - how about AcceptCachedToken ?
There was a problem hiding this comment.
And maybe make it async from the start? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this request
Testing
Performance impact
Documentation